S3 Go MVP examples refinement (address #2657) #2719
Conversation
|
needs: README at the service level. |
|
@indrora Sent responses via Slack |
Brings everything in line with standards.
|
@lkdavies back to you if there's any further edits you want otherwise it's ready for merge? |
|
Hi @indrora , no need for a second round of edits (only needed if you added new content). Thanks! |
|
This failed check and will not be merged until check passes |
|
The linter can't handle our situation it appears. I'm going to investigate further. |
There was a problem hiding this comment.
The scenario doesn't appear to provide much feedback to the user. Scenarios typically either run straight through, printing output about their actions along the way, or follow a question/answer format. I tried running it to confirm my read of the code, and found that it doesn't run. It errors out at line 57--CreateBucket.
Also, add at least one integration test and have the test reviewed.
The sample now outputs more information instead of just doing things silently; this just makes it a little easier to see what is going on. Additionally, there were some pretty nasty logic errors I discovered. Most aggregious of them was a failure to properly open files to write; this is because I used the wrong Open call (go wants `os.Create(...)` instead of `os.Open(...)`, which threw me off from working in Python). I've cleaned up those logic errors and added clearer error handling. Additionally, the logic for emptying a bucket is much cleaner.
|
@Laren-AWS quick review? The lint seems to be borked, once again. |
|
It doesn't look like there are any tests, just test files that have been deleted and instructions on how to run tests. Unless they're not showing up in the changed files. |
1 similar comment
|
It doesn't look like there are any tests, just test files that have been deleted and instructions on how to run tests. Unless they're not showing up in the changed files. |
This starts to re-arrange the SDK examples that are already there into a more coherent end to end scenario as described in the tracked ticket