Java V2 Added an example for tix V1818828107 #7486
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
scmacdon
added
Java-v2
scmacdon
changed the title
|
Please build the PR to your CDD and put the link in the PR. |
tkhill-AWS
reviewed
Jun 25, 2025
There was a problem hiding this comment.
I don't understand why this file and all the rest show the top part as deleted, when it looks like all you did was add some javadoc to the method.
tkhill-AWS
requested changes
Jul 2, 2025
There was a problem hiding this comment.
The problem is that this example doesn't use the describeLogStreams method, which is the API method/page it appears on in the Code Examples library.
If the the intent of the example is to display logged content, this should be moved to a different place, because here it is misleading.
Also, this class contains several unused imports.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request adds a new code example for tix V1818828107, .
Cloud Desktop Build is available.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.