#27 - allow linking to a section with hash syntax #34
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chasenlehara
approved these changes
May 18, 2017
build/make_default_helpers.js
Outdated
| hashParts = name.split("#"); | ||
|
|
||
| if(hashParts.length > 1){ | ||
| name = hashParts[0]; |
There was a problem hiding this comment.
It’d be nice if there were comments so people reading this code could more easily understand what’s going on here.
build/make_default_helpers.js
Outdated
|
|
||
| docObject = docMap[name] | ||
| if (docObject) { | ||
| linkText = parts && parts[2] ? parts[2] : docObject.title || name; | ||
| description = docObject.description || name; | ||
|
|
||
| return '<a href="' + urlTo(name) + '" title="' + stripMarkdown(description) + '">' + linkText + '</a>'; | ||
| return '<a href="' + urlTo(name) + (hashParts.length > 1 ? ("#" + hashParts.slice(1).join("#")) : "") + '" title="' + stripMarkdown(description) + '">' + linkText + '</a>'; |
There was a problem hiding this comment.
I think this would be easier to read if this logic happened before the string concatenation.
Also, you could use shift to get the name and then you wouldn't have to slice the array here. 😝
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves #27