Skip to content

set auth region when service url is used #2

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 11, 2023

Conversation

amidofu
Copy link

@amidofu amidofu commented May 10, 2023

Issue #, if available:

Description of changes:
set AmazonCloudWatchLogsConfig.AuthenticationRegion by AWSLoggerConfig.Region (will be copied from AWSTarget)

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@amidofu amidofu marked this pull request as ready for review May 10, 2023 06:29
Copy link

@taka-boostdraft taka-boostdraft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@taka-boostdraft taka-boostdraft merged commit aba6a01 into master May 11, 2023
@taka-boostdraft taka-boostdraft deleted the user/amidofu/add_auth_region branch May 11, 2023 08:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants