add fast path

[withinboredom]

Summary by CodeRabbit

• Performance Improvements
  • Optimized processing speed when using the default raw filter by bypassing unnecessary filtering steps, enhancing overall efficiency.

[coderabbitai]

Walkthrough

The update adds a fast path optimization in the php_sapi_filter function for when the default filter is FILTER_UNSAFE_RAW. This bypasses the usual filtering steps by directly creating and registering a raw variable, reducing overhead. The duplicate cookie name check now uses branch prediction hints but remains functionally unchanged.

Changes

File(s)	Change Summary
ext/filter/filter.c	Introduced fast path in php_sapi_filter for FILTER_UNSAFE_RAW to skip unnecessary filtering and duplicate processing; added branch prediction hint in duplicate cookie name check.

Poem

A shortcut for raw, so swift and neat,
No more filtering loops to repeat!
Direct and simple, the path is clear,
The code hops forward without a fear.
🐇✨

Quick as a flash, the data flows—
A rabbit’s joy in how it goes!

---

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 09d1026 and 5f0b02d.

📒 Files selected for processing (1)

• ext/filter/filter.c (2 hunks)

🚧 Files skipped from review as they are similar to previous changes (1)

• ext/filter/filter.c

⏰ Context from checks skipped due to timeout of 90000ms (7)

• GitHub Check: MACOS_ARM64_DEBUG_NTS
• GitHub Check: BENCHMARKING
• GitHub Check: WINDOWS_X64_ZTS
• GitHub Check: FREEBSD
• GitHub Check: LINUX_X32_DEBUG_ZTS
• GitHub Check: LINUX_X64_DEBUG_ZTS_ASAN
• GitHub Check: LINUX_X64_RELEASE_NTS

✨ Finishing Touches

• 📝 Generate Docstrings

🧪 Generate Unit Tests

• Create PR with Unit Tests
• Post Copyable Unit Tests in Comment
• Commit Unit Tests in branch optimize-filters

---

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Explain this complex logic.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai explain this code block.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and explain its main purpose.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR.
• @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
• @coderabbitai auto-generate unit tests to generate unit tests for this PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[coderabbitai]

Actionable comments posted: 1

📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 89be689 and 9d25251.

📒 Files selected for processing (1)

• ext/filter/filter.c (2 hunks)

⏰ Context from checks skipped due to timeout of 90000ms (7)

• GitHub Check: FREEBSD
• GitHub Check: BENCHMARKING
• GitHub Check: WINDOWS_X64_ZTS
• GitHub Check: LINUX_X64_RELEASE_NTS
• GitHub Check: LINUX_X64_DEBUG_ZTS_ASAN
• GitHub Check: MACOS_ARM64_DEBUG_NTS
• GitHub Check: LINUX_X32_DEBUG_ZTS

🔇 Additional comments (3)

ext/filter/filter.c (3)

282-282: Good optimization with cached variables.

The introduction of is_raw and var_len variables improves performance by avoiding repeated function calls and comparisons. This is a clean optimization.

Also applies to: 285-286

---

318-318: Efficient use of cached variable length.

Using the pre-calculated var_len instead of calling strlen(var) again is a good performance optimization.

---

322-364: Well-designed optimization for common case.

The fast path optimization is architecturally sound and should provide meaningful performance improvements for the FILTER_UNSAFE_RAW case, which is likely common. The implementation correctly handles edge cases and maintains the same external behavior.