Rubocop #596
Rubocop #596
Conversation
|
Holy hell this is amazing haha. I love this but would it be a huge pain to split it up into smaller pull requests that are easier to grok? Maybe one to convert the rspec syntax, one fixing up the shell script syntax, one fixing all the warnings in ruby code from Rubocop, one fixing the C code, etc... ? |
|
@brianmario totally, let's land #592 and #595 first, and then I'll break this one up some more |
|
Ok, ready to rebase here. |
|
Rebased (and green). I found a bug in extconf.rb that uncovered a bunch more C warnings, which I've fixed in #628 and then rebased this on top. |
|
Ready for another rebase. |
|
Rebased but Travis is refusing to build. |
|
Looks like Travis backed up this afternoon. I'll check back tomorrow. |
|
green except for a spurious failure |
|
Looks like rbx is still grumpy about the 10000 statements tests |
|
I think there's a more general Rubinius GC problem with calls to This crash is a new one, it's in Thanks for updating the PR! |
|
Rebased but rbx is still grumpy and now mysql 5.7 is throwing a fit? |
|
Oh RBX is actually leaking a connection now. MySQL 5.7 says |
|
I did some reading about the MySQL 5.7.8 changes to performance-schema, but I didn't get it. https://dev.mysql.com/doc/refman/5.7/en/performance-schema-variable-table-migration.html Thanks for the rebase! I marked this as a 0.4.1 item because I want to get 0.4.0 out the door this month, so just FYI it'll be at least a little longer before I get to merging it. |
|
@sodabrew ok, seems like the mysql issue isn't caused by this PR, and I'm not able to reproduce the RBX issue locally. Let me know if there's anything I can help with. |
|
Has merge conflicts - Presumably the be_an_instance_of change touches the same diff context. |
|
Yep, rebased now! |
| header = [prefix, h].compact.join '/' | ||
| asplode h unless have_header h | ||
| asplode h unless have_header header |
| ).select do |flag| | ||
| try_link('int main() {return 0;}', flag) | ||
| end.each do |flag| | ||
| ).select { |flag| try_link('int main() {return 0;}', flag) }.each do |flag| |
|
|
||
| if !encoding.nil? && encoding[1] != "NULL" | ||
| name = "\"#{encoding[1]}\"" | ||
| name = if encoding.nil? || encoding[1] == 'NULL' |
There was a problem hiding this comment.
nice improvement to readability here.
|
And we're off to the races! |
|
🎊 |
builds further on #595
@sodabrew apologies for the chain of PRs ❤️