Webworkify + Uglify-js + Require.js not getting along

[etpinard]

Hi, I'm trying to load up a browserify --standalone bundle that includes webworkify that been minified with uglifyjs using the --mangle and --compress options in Require.js.

Problem

Require.js fails to load the bundle:

Reproducible example

See https://gist.github.com/etpinard/8ec2c29210d5adee049d54bb427bbbe6

Observations

This line seems to be causing the issue when compressed by uglifyjs

Replacing

'var f = require(' + stringify(wkey) + ');' +
'(f.default ? f.default : f)(self);'

by

'var f = require('+stringify(wkey)+');' +
'(f.default ? f.default : f)(self);'

and running browserify and uglifyjs without the --compress option is enough to replicate the problem listed above.

[mourner]

I'm really puzzled by this. Why would adding spaces around + sings in webworkify code affect things in any way?

[etpinard]

This one is definitively strange. It may be a bug with Require.js itself?

[mourner]

@etpinard would you mind checking if the same thing happens in #31? Just in case.

[etpinard]

I get the same Require.js error using off mourner:no-eval , unfortunately.

[etpinard]

This commit 31c27ef appear to fix this issue.

[mourner]

@etpinard but why?

[mourner]

Since this seems like a require+uglify bug, should we close this issue and wait for upstream fixes?

[etpinard]

Since this seems like a require+uglify bug

I believe this is a Require.js bug, but I haven't had the time to investigate further.

For our needs, I was able to fix this issue using a dirty string .replace here and test it here. So you can close this issue if you like.

Thanks for your time.