-
Notifications
You must be signed in to change notification settings - Fork 39
Improve Local Testing experience #114
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Calculate local_identifier based on local_mode.
…erstack-cypress-cli into CYP_682_Unit_test
- Adding checks and params for local, local mode, and sync inferred.
…erstack-cypress-cli into improve_local_testing
…erstack-cypress-cli into improve_local_testing
…erstack-cypress-cli into CYP_682_Unit_test
- If the user passed anything explicitly, then it is not inferred. - This is to understand which of the "auto-fallback" flows does CLI fall in. - Inverted the logic of the *_inferred events.
…erstack-cypress-cli into CYP_682_Unit_test
…erstack-cypress-cli into CYP_682_Unit_test
SagarGaniga
reviewed
Mar 3, 2021
…ack-cypress-cli into CYP_682_Unit_test
…ack-cypress-cli into CYP_682_Unit_test
suryart
reviewed
Mar 3, 2021
Cyp 682 unit test
removed local object creation
suryart
reviewed
Mar 5, 2021
…ed in browserstack.json
Local mode and id validation
SagarGaniga
approved these changes
Mar 11, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added local_mode(on-demand/always-on).
Added cli args i.e. local, local_identifier & local_mode.
Updated --help to support new cli args
Downloading and starting of binary on runtime if the user hasn't started the binary.