[Issue #11] Support for localIdentifier capability #13
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
suryart
requested changes
Apr 22, 2020
bin/helpers/capabilityHelper.js
Outdated
| @@ -33,6 +33,11 @@ const caps = (bsConfig, zip) => { | |||
| if (bsConfig.connection_settings.local === true) obj.local = true; | |||
| logger.log(`Local is set to: ${obj.local}`); | |||
|
|
|||
| // Local Identifier | |||
| obj.localIdentifier = null; | |||
| if (bsConfig.connection_settings.localIdentifier) obj.localIdentifier = bsConfig.connection_settings.localIdentifier; | |||
There was a problem hiding this comment.
Check local is true as well.
srebs
reviewed
Apr 22, 2020
README.md
Outdated
| @@ -80,6 +81,7 @@ The following table provides a reference for all the options that can be provide | |||
| | `project` | Name of your project. This will be displayed in your Automate dashboard, and you'll be able to search & filter your tests based on the project name. | A string providing the name of the project | | |||
| | `customBuildName` | Helps in providing a custom name for the build. This will be displayed in your Automate dashboard, and you'll be able to search & filter your tests based on the build name. | A string providing the name of the build | | |||
| | `local` | Helps in testing websites that cannot be accessed in public network. If you set this to `true`, please download the Local binary and establish a local connection first (you can learn how to do so [here](https://www.browserstack.com/local-testing/automate#command-line)) | Boolean: `true` / `false`. Set this to `true` if you need to test a local website. Set this to `false` if the website is accessible publicly. | | |||
| | `localIdentifier` | Configure the test script to run through a specific connection. To do so, set the value of localIdentifier capability to be a unique connection name. | Set this when `local` is set to `true`. | | |||
There was a problem hiding this comment.
Change the text in 2nd column to:
The BrowserStack Local tunnel that should be used to resolve requests. This is applicable only when you start a Local binary with a local identifier. Your tests might fail if you use an invalid local identifier. This option will be ignored if local option is set to false.
Change the text in 3rd column to:
A string if a tunnel identified by the Local identifier should be used (should be same as the one used to start the Local binary). Set this to null (default value) to resolve requests using Local without a Local identifier.
suryart
approved these changes
Apr 22, 2020
SagarGaniga
approved these changes
Apr 22, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description: Provides support for localIdentifier capability to be used while running local sessions
Issue Link: #11