text resizing based on the terminal column's width for sync logs #136
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 75ba9d9.
SagarGaniga
reviewed
Apr 19, 2021
bin/helpers/sync/syncSpecsLogs.js
Outdated
| @@ -13,7 +13,8 @@ let specSummary = { | |||
| "specs": [], | |||
| "duration": null | |||
| } | |||
|
|
|||
| let noWrap = utils.searchForOption('--no-wrap') | |||
There was a problem hiding this comment.
can we add validation around --no-wrap?
| @@ -221,6 +221,9 @@ var argv = yargs | |||
| 'local-config-file': { | |||
| describe: Constants.cliMessages.RUN.LOCAL_CONFIG_FILE, | |||
| type: "string" | |||
| }, | |||
| 'no-wrap': { | |||
There was a problem hiding this comment.
add a default value, type, and alias
bin/helpers/sync/syncSpecsLogs.js
Outdated
| @@ -81,7 +82,7 @@ let printSpecsStatus = (bsConfig, buildDetails) => { | |||
| whileProcess(callback) | |||
| }, | |||
| function(err, result) { // when loop ends | |||
| logger.info("\n--------------------------------------------------------------------------------") | |||
| noWrap ? logger.info("\n--------------------------------------------------------------------------------") : logger.info("\n" + "-".repeat(terminalWidth)) | |||
There was a problem hiding this comment.
can we use noWrap? to determine separator length in both cases? Something like
logger.info("-".repeat(noWrap ? X : terminalWidth))
There was a problem hiding this comment.
The X is default and we would want the existing behaviour to continue in case of a no-wrap. We can make it something like:
logger.info("-".repeat(noWrap ? 80 : terminalWidth))Where 80 is the current number of the - which are being printed.
- Added util for setting the no-wrap on process level as a BOOL val. - Moved the no-wrap logic to centralizeds place. - Added default value and the type accepted in the help text for yargs.
suryart
changed the title
suryart
changed the title
SagarGaniga
approved these changes
Apr 21, 2021
|
LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We will be widening or shorting the width of the column which shows the sync result logs for individual specs based on the current terminal's column width.
This PR adds the dynamically adjusting the specs listing column width based on the terminal/process' col size. Provides an option
--no-wrapto disable the feature in case the user does not want the column to be resized.