Skip to content

Non zero exit code for errors #175

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Oct 25, 2021
Merged

Non zero exit code for errors #175

merged 3 commits into from
Oct 25, 2021

Conversation

nagpalkaran95
Copy link
Collaborator

@nagpalkaran95 nagpalkaran95 commented Oct 20, 2021 •
edited
Loading

Exit with non zero exit code for errors before sync mode is started or used in async mode.

@nagpalkaran95 nagpalkaran95 mentioned this pull request Oct 20, 2021
Open
karanshah-browserstack
karanshah-browserstack previously approved these changes Oct 20, 2021
View reviewed changes
Copy link
Collaborator

@karanshah-browserstack karanshah-browserstack left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This won't solve issues as npm install failed and other errors which occur after the build is created.

@nagpalkaran95 nagpalkaran95 merged commit 4a7acc7 into master Oct 25, 2021
@nagpalkaran95 nagpalkaran95 deleted the exit_code branch October 25, 2021 10:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@karanshah-browserstack karanshah-browserstack karanshah-browserstack approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nagpalkaran95 @karanshah-browserstack