Make config management developer friendly #43
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nagpalkaran95
dismissed stale reviews from karanshah-browserstack and suryart
via
2ae1f6f
suryart
reviewed
Aug 10, 2020
bin/helpers/config.js
Outdated
| // load config based on env | ||
| require('custom-env').env(config.env) | ||
| if(config.env === "production") { | ||
| config.uploadUrl = 'https://api-cloud.browserstack.com/automate-frameworks/cypress/upload'; |
There was a problem hiding this comment.
Can we move these to config.json and load that JSON on line 1?
suryart
approved these changes
Aug 10, 2020
karanshah-browserstack
approved these changes
Aug 10, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Tasks