Sync CLI Part 3 #67
Merged
Sync CLI Part 3 #67
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
suryart
commented
Oct 9, 2020
suryart
commented
- Added sync CLI total, passed, failed, skipped, statistics.
- Added showing the completed in time with num of machines.
- Returns Promise for next part, i.e. Part 4
- Added sync CLI total, passed, failed, skipped, statistics. - Added showing the completed in time with num of machines.
SagarGaniga
reviewed
Oct 9, 2020
bin/helpers/sync/specsSummary.js
Outdated
| logger.info(`Total tests: ${summary.total}, passed: ${summary.passed}, failed: ${summary.failed}, skipped: ${summary.skipped}`); | ||
| logger.info(`Done in ${time} using ${machines} machines\n`); | ||
|
|
||
| return new Promise((resolve, _reject) => { |
There was a problem hiding this comment.
why do we need a promise here?
There was a problem hiding this comment.
SagarGaniga
approved these changes
Oct 13, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.