CYP-442 sync cli part 1 #70
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ss-cli into CYP_442_sync_cli_part_1
suryart
reviewed
Oct 12, 2020
| @@ -58,7 +58,7 @@ module.exports = function run(args) { | |||
| // Create build | |||
| return build.createBuild(bsConfig, zip).then(function (data) { | |||
| let message = `${data.message}! ${Constants.userMessages.BUILD_CREATED} with build id: ${data.build_id}`; | |||
| let dashboardLink = `${Constants.userMessages.VISIT_DASHBOARD} ${config.dashboardUrl}${data.build_id}`; | |||
| let dashboardLink = `${Constants.userMessages.VISIT_DASHBOARD} ${data.dashboard_url}`; | |||
There was a problem hiding this comment.
Nice. Is the data.dashboard_url the complete URL? 🤩
| printSpecsStatus(); | ||
| }).then((data) => { | ||
| exports.pollBuildStatus = (bsConfig, buildDetails) => { | ||
| logBuildDetails(bsConfig, buildDetails); |
There was a problem hiding this comment.
Is there a reason we cannot use promise based calls here? printSpecsStatus in next call would require bsConfig and buildId for polling. I guess that can be taken from buildDetails then?
There was a problem hiding this comment.
We don't need promise call here as
- There are no async calls
- The end is always
resolveand never areject
suryart
approved these changes
Oct 13, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.