Add support for ccf flag for O11y #779
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -61,6 +61,9 @@ module.exports = function run(args, rawArgs) { | |||
| markBlockStart('setConfig'); | |||
| logger.debug('Started setting the configs'); | |||
|
|
|||
| // set cypress config filename | |||
| utils.setCypressConfigFilename(bsConfig, args); | |||
There was a problem hiding this comment.
Let's move our code in end in this scenario?
There was a problem hiding this comment.
That would require moving more code around. This change shouldn't affect handling of other products. This method sets the value of cypress_config_file in bsConfig which is only accessed by O11y helper method amongst all methods placed between this line & the earlier placement of this function call.
07souravkunda
approved these changes
Feb 15, 2024
rev-doshi
reviewed
Feb 16, 2024
|
Tested, working fine. |
RutvikChandla
approved these changes
Feb 19, 2024
pranavj1001
approved these changes
Feb 22, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.