Skip to content

[Sync CLI] Retry polling in case of network issue #91

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Nov 18, 2020

Conversation

SagarGaniga
Copy link
Collaborator

If there is some network issue while polling for data from our server, retry few times and handle the error properly with a descriptive error message.

@SagarGaniga SagarGaniga changed the base branch from master to sync-cli November 10, 2020 12:39
Copy link
Collaborator

@karanshah-browserstack karanshah-browserstack left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@SagarGaniga SagarGaniga merged commit a13a494 into sync-cli Nov 18, 2020
@SagarGaniga SagarGaniga deleted the sync-cli-retry-polling branch November 18, 2020 11:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants