update https-proxy-agent to fix vulnerability #49
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes https://nodesecurity.io/advisories/593 Looked at the changelog and it doesn't appear there is any breaking change relevant to the library. https://github.com/TooTallNate/node-https-proxy-agent/blob/master/History.md#200--2017-06-26
|
@evan-scott-zocdoc Did you try running tests locally? travis build is failing since credentials are outdated. we are fixing it soon |
|
One of the tests failed for me locally, but the same tests fails for me too on master. So I don't know what's up.
(latest macOS, node 8.11.2) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes https://nodesecurity.io/advisories/593
Looked at the changelog and it doesn't appear there is any
breaking change relevant to the library.
https://github.com/TooTallNate/node-https-proxy-agent/blob/master/History.md#200--2017-06-26