-
Notifications
You must be signed in to change notification settings - Fork 24
fix($drag): offset dragged element relative to first positioned ancestor #64
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
1 similar comment
heh, can't argue with those coverage stats. |
definitely, that's awesome. Let me take a look at this |
* Provides read-only equivalent of jQuery's offset function: | ||
* http://api.jquery.com/offset/ | ||
*/ | ||
offset: function (element) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I was previously putting helpers like this in src/utils.js --- if moving them here and refactoring, please delete the old dead code and make sure this new code is being used consistently
1 similar comment
1 similar comment
something got messed up with the coveralls account --- could you rebase and re-push? I just want to see the accurate coverage info before landing |
1 similar comment
the coverage looks okay (non-regression at least), although for whatever reason coveralls is not reporting the new file on their UI (they seem to be suffering from some new bugs lately!) |
i noticed the new travis file has node v0.1? |
it's the same as 0.10, it's just formatted differently |
The demo still works nicely, so as far as I'm concerned it's safe to merge --- it would be good to add to the demo app with a little showcase of your fix. LGTM, landing |
fixes #63
Notes:
At some point the DOM utils stuff could be merged with $dndPosition perhaps.