Skip to content

chore: update GettingStarted example with something you can run #284

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 23, 2020

Conversation

thymikee
Copy link
Member

Summary

The example we had was based on some 3rd party code without source. Let's change to so it's easier for people to give the library a try. I've put the implementation into our test suite.

Test plan

Added a new test for QuestionBoard from the docs.

@thymikee thymikee requested review from cross19xx and Esemesek April 23, 2020 13:59
@thymikee
Copy link
Member Author

CI is failing because of GitHub issues, will try tomorrow

@thymikee thymikee force-pushed the chore/update-getting-started branch from 1b33d8a to cf5decf Compare April 23, 2020 14:24
@thymikee thymikee merged commit 61a83e9 into master Apr 23, 2020
@thymikee thymikee deleted the chore/update-getting-started branch April 23, 2020 14:27
@cross19xx
Copy link
Contributor

It shows here that CI passed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants