feat: add toJSON to render; cleanup shallow #35
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Esemesek
reviewed
Oct 16, 2018
src/debug.js
Outdated
| @@ -1,7 +1,7 @@ | |||
| // @flow | |||
| import * as React from 'react'; | |||
| import prettyFormat, { plugins } from 'pretty-format'; // eslint-disable-line import/no-extraneous-dependencies | |||
| import shallow from './shallow'; | |||
| import { shallow } from '.'; | |||
There was a problem hiding this comment.
Is this a cyclic dependency?
Esemesek
approved these changes
Oct 16, 2018
|
Can you also update documentation? |
Esemesek
approved these changes
Oct 16, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Exposing
toJSONso it's possible to snapshot/debug the fully rendered component.By the way removed the dead code in
shallowthat was not supported (we've never actually wanted to supportshallow(Component)as it doesn't make sense without passing props.Fixes #33.
Test plan
Added a test, which renders funny because of our mocks.