-
Notifications
You must be signed in to change notification settings - Fork 5
Closed
Description
Checking the entry on PyPI, it is indicated this package should work with at least Python 3.6. However, attempting to run this package with Python 3.6 will first result in the message:
File "<stdin>", line 1, in <module>
File "/home/hcsolomon/tdworkflow/tdworkflow/__init__.py", line 5, in <module>
from . import (
File "/home/hcsolomon/tdworkflow/tdworkflow/attempt.py", line 1, in <module>
import dataclasses
ModuleNotFoundError: No module named 'dataclasses'
which is easily fixed by installing the backport dataclasses
found here.
After this, another problem arises due to the datetime
type in Python 3.6:
target = '2019-12-15T07:27:16Z'
def parse_iso8601(target: str) -> Optional[datetime]:
if not target:
return None
> return datetime.fromisoformat(target.replace("Z", "+00:00"))
E AttributeError: type object 'datetime.datetime' has no attribute 'fromisoformat'
Because of this, the package is incompatible with Python 3.6, but I will be sending a PR that would allow this by parsing the ISO format string using dateutils
. This would make the package compatible with Python 3.6 so long as the dataclasses
package is also installed.
Metadata
Metadata
Assignees
Labels
No labels