-
-
Notifications
You must be signed in to change notification settings - Fork 648
Switch to CircleCI #2603
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Switch to CircleCI #2603
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,38 @@ | ||
version: 2.1 | ||
|
||
# Default actions to perform on each Emacs version | ||
default: &default-steps | ||
steps: | ||
- checkout | ||
- run: apt-get update && apt-get install make leiningen=2.8.1-6 -y | ||
- run: make elpa | ||
- run: emacs --version | ||
- run: make test | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Maybe we should have separate steps for the testing and linting, so that we would get nicer reports at the end? There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. The issue with this is that the majority of CI time is spent getting the image booted and into the right state to run the tests. The lint and test phases only take 6s and 3s. Given this is a free service, I wanted to try and minimise resource usage where practicable. If we wanted better errors from CircleCI we could look at producing JUnit XML reports which they can render. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Fair enough. My only issue is that the linting produces a lot of (hard to read) output and this makes it hard to find the tests at least for me. |
||
- run: make lint | ||
|
||
jobs: | ||
test-emacs-25: | ||
docker: | ||
- image: silex/emacs:25-dev | ||
entrypoint: bash | ||
<<: *default-steps | ||
|
||
test-emacs-26: | ||
docker: | ||
- image: silex/emacs:26-dev | ||
entrypoint: bash | ||
<<: *default-steps | ||
|
||
test-emacs-master: | ||
docker: | ||
- image: silex/emacs:master-dev | ||
entrypoint: bash | ||
<<: *default-steps | ||
|
||
workflows: | ||
version: 2 | ||
ci-test-matrix: | ||
jobs: | ||
- test-emacs-25 | ||
- test-emacs-26 | ||
- test-emacs-master |
This file was deleted.
This file was deleted.
This file was deleted.
This file was deleted.
This file was deleted.
This file was deleted.
This file was deleted.
This file was deleted.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we need Lein at all?
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
cider-jack-in-clj&cljs
requireslein
to be around. See the test failure at https://circleci.com/gh/danielcompton/cider/11 when removing Leiningen from the build.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'll take a look at the test. We don't do any real jack-ins anywhere in the tests, so probably something just needs to be stubbed.