Use clojure-find-ns safely
#3428
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bbatsov
reviewed
Aug 24, 2023
cider-util.el
Outdated
| @@ -114,9 +114,15 @@ instead." | |||
| (clojure-backward-logical-sexp 1) | |||
| (cider--text-or-limits bounds (point) end))))) | |||
|
|
|||
| (defun cider--clojure-find-ns () | |||
There was a problem hiding this comment.
Or just cider--find-ns. I guess this one can even be considered public.
There was a problem hiding this comment.
There happens to be a defun cider--find-ns already, which does something else
There was a problem hiding this comment.
Ah, yes - the one that goes to the ns. I'm guessing it'd still be confusing to have cider--find-ns and cider--clojure-find-ns, as it's confusing for me even knowing how we ended up here. :-) Let's name the new function cider-get-ns, cider-current-ns or something like this.
There was a problem hiding this comment.
cider-get-ns-name?
Aligned with clojure.core/ns-name
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bumps clojure-mode, introducing a
cider-get-ns-namewrapper and using it everywhere.Callsites handle nil when due.