Skip to content

Add transformation-builder package #527

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
May 24, 2022

Conversation

strausr
Copy link
Contributor

@strausr strausr commented May 4, 2022

Pull request for @cloudinary/url-gen

What does this PR solve?

Add transformation-builder package
Note that the package will first need to be released. We will then update the dependency here.

@strausr strausr requested a review from patrick-tolosa May 4, 2022 06:57
Copy link
Contributor

@patrick-tolosa patrick-tolosa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the test are failing because cloudinaryLtd is private.
Lets move it to public and make sure the tests pass before we approve this PR.

@strausr strausr requested a review from patrick-tolosa May 12, 2022 09:53
@strausr strausr merged commit cd691c8 into master May 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants