Dotted column notation #5
Conversation
|
Awesome! Your changes are very much appreciated 👍 Your changes look good at first sight, I'll review this more thoroughly shortly. |
|
Ok, I hope my contribution will benefit for project. |
Absolutely! 👍 I'd love to merge this soon to move this project forward. The first commit looks good to me. The second commit also looks good to me, however I'd like to question if this is really needed or if this might actually do more harm in the future. This project currently aims to be the reference implementation of the https://github.com/clue/json-query-language specification. The current spec (draft) demands support for dotted notation and makes no mention of any other separators. Adding support for other separators essentially allows for incompatible filter definitions, which is something I'd like to avoid, unless we find a reasonable wait to improve interoperability. If you deem this to be a useful feature, I'd love to discuss this in the context of the specification (new issue?). Also, one thing that will be needed before #3 can be considered completed is escaping of the dot by prefixing it with an backslashes. I'll leave to up to you if you if this ought to be implemented as part of this PR or at a later stage. Either way, thanks for your PR! 👍 |
|
Thanks for your contribution, I've just merged your first commit! 👍 As per the above discussion, if you deem it useful to support custom separator characters, I'd love to discuss this in another ticket. Thanks! |
Add support nested attributes #3