Enhancement: Run tests on GitHub Actions #1
Conversation
.github/workflows/integrate.yaml
Outdated
| run: "php tests/run-tests.php" | ||
| env: | ||
| NO_INTERACTION: "true" |
There was a problem hiding this comment.
I think we should add some useful arguments. First -q is equivalent to setting NO_INTERACTION. Then, at least in the long run, parallel test execution makes sense (-j2 or maybe -j3 seem to be good for GH actions, currently). And --show-diff is helpful to diagnose failing tests.
We could also create a junit.out.xml by setting the environment variable TEST_PHP_JUNIT to the desired filename, and then packing the file for download. Might be overkill for now, though.
|
Thanks for the PR! |
localheinz
force-pushed
the
feature/tests
branch
3 times, most recently
from
beea674 to
4868d8d
Compare
| strategy: | ||
| matrix: | ||
| php-version: | ||
| - "7.2" |
There was a problem hiding this comment.
Using PHP 7.2 here as laid out in README.md.
There was a problem hiding this comment.
Okay, let's go with PHP 7.2 then (although I'm not sure which version actually runs on php.net).
|
Thank you, @cmb69! |
This pull request