This repository was archived by the owner on Jul 19, 2025. It is now read-only.
Change directory with a block while running the reporter #41
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -31,13 +31,16 @@ def run | |||
| languages_to_analyze.each do |language| | |||
| engine = LANGUAGES[language].new(engine_config: engine_config) | |||
| reporter = CC::Engine::Analyzers::Reporter.new(engine_config, engine, io) | |||
| reporter.run | |||
|
|
|||
| Dir.chdir(directory) do | |||
There was a problem hiding this comment.
Would it work to wrap the entire Duplication#run body in the chdir? That is closer to what we do in other repos and also closer to the original intention of doing it in the constructor
There was a problem hiding this comment.
Sure, I'll make that change. 👍
dblandin
force-pushed
the
devon/chdir-into-directory-for-each-engine
branch
from
6d03a99 to
43bfc9e
Compare
|
👍 |
dblandin
added a commit
that referenced
this pull request
Nov 11, 2015
…r-each-engine Change directory with a block while running the reporter
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I experienced some weirdness recently with the error described in #40 showing up multiple times in the container logs. Using the block form of chdir seems to have removed that repetition, with just one expected occurrence showing up. I wonder if there's some strangess around changing directories and multiple jruby threads that I still don't understand, but using the block form seems to be a safe move.
Thoughts?