Reduce java memory options to 128M #43
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These numbers were (and still are) a bit of a shot in the dark: 1. This cannot limit total process memory; it's technically a limit on the JVM's heap size, which will indirectly impact total process memory[1] 2. With the previous limit of 384M, it's suspected a fork operation would require double that (768M), which is already over the 512M engine-level limit Therefore, we're going to experiment with a lower, 128M limit. 1: http://stackoverflow.com/questions/1493913/how-to-set-the-maximum-memory-usage-for-jvm
|
LGTM, enough for a try at any rate. |
pbrisbin
added a commit
that referenced
this pull request
Nov 17, 2015
Reduce java memory options to 128M
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These numbers were (and still are) a bit of a shot in the dark:
JVM's heap size, which will indirectly impact total process memory[1]
would require double that (768M), which is already over the 512M
engine-level limit
Therefore, we're going to experiment with a lower, 128M limit.
1: http://stackoverflow.com/questions/1493913/how-to-set-the-maximum-memory-usage-for-jvm
/cc @codeclimate/review