PHP Parser: handle INF/NaN nodes #71
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I tracked this back to this constant number in a source file. It turns out the literal INF constant in a PHP source if fine: the parser represents constants directly using the identifier, so it's fine in JSON. But the constant number is larger than PHP's max number, so it basically overflows & get represented as INF after parsing. On the belief that similar code might result in a NaN constant, I'm also covering that one. This represents both values using constant strings that are unlikely to actually appear in anyone's source code.
wfleming
force-pushed
the
will/php-inf-nan
branch
from
d17e5c3 to
f281005
Compare
|
LGTM |
wfleming
added a commit
that referenced
this pull request
Jan 4, 2016
PHP Parser: handle INF/NaN nodes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I tracked this back to this constant number in a source file.
It turns out the literal INF constant in a PHP source is fine:
the parser represents constants directly using the identifier, so
it's fine in JSON.
But the constant number is larger than PHP's max number, so it basically
overflows & get represented as INF after parsing.
On the belief that similar code might result in a NaN constant, I'm also
covering that one. This represents both values using constant strings
that are unlikely to actually appear in anyone's source code.
👀 @codeclimate/review