This repository was archived by the owner on Jul 19, 2025. It is now read-only.
Install npm as part of docker build #80
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Closing because of circle failures. Investigating why the docker build doesn't work locally without |
|
Rebuilt the image locally without cache and that did the trick fwiw. |
| @@ -9,7 +9,7 @@ COPY vendor/php-parser/composer.json /usr/src/app/vendor/php-parser/ | |||
| COPY vendor/php-parser/composer.lock /usr/src/app/vendor/php-parser/ | |||
|
|
|||
| RUN curl --silent --location https://deb.nodesource.com/setup_5.x | bash - | |||
| RUN apt-get update && apt-get install -y nodejs python openssh-client php5-cli php5-json | |||
| RUN apt-get update && apt-get install -y nodejs npm python openssh-client php5-cli php5-json | |||
There was a problem hiding this comment.
@ABaldwinHunter your issue is because of the dependency between the installation here and the nodesource install a line above. You should combine them to one RUN invocation with && so that they are cached (and invalidated) together.
There was a problem hiding this comment.
@pbrisbin cool, thanks for the explanation!
There was a problem hiding this comment.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@codeclimate/review
Fixes the following error I began seeing locally: