Smaller Image, minor build improvements #26
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
wfleming
commented
Feb 9, 2016
wfleming
commented
- Add Makefile
- Use Makefile in CI
- Use slim base image in Dockerfile (resultant image is about 2/3 smaller, shaving ~400MB)
- Add maintainer email address
added 3 commits
February 9, 2016 12:14
Tagging a base image is good practice regardless. The slim variant also shaves ~400MB off our final image. And having a maintainer email is nice.
Use the makefile to build & tag the image, as well as run tests in it.
|
@codeclimate/review |
|
LGTM |
wfleming
added a commit
that referenced
this pull request
Feb 9, 2016
Smaller Image, minor build improvements
|
"Looks Good, Mutant Turtles"? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.