forked from eslint/eslint
-
Notifications
You must be signed in to change notification settings - Fork 2
Abh upstream v1.10.3 #6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nt#4220) Also updated docs to note that either node or loc (or both) must be supplied. Code will now throw clearer message if neither is supplied and will not throw TypeError if node is not supplied.
Fix: eslint.report can be called w/o node if loc provided (fixes eslint#4220)
Fix: Add the missing "as-needed" documentation to the radix rule (fixes eslint#4364)
Fix: Display singular/plural version of "line" in message
Update: Add Popular Style Guides (fixes eslint#4320)
Fix: no-undef-init should ignore const (fixes eslint#4284)
Update: Refactor eslint.verify args (fixes eslint#4395)
Update: Allow empty arrow body (fixes eslint#4411)
Docs: Document semi-spacing behaviour (fixes eslint#4404)
Revert "Update: Allow empty arrow body (fixes eslint#4411)"
Fix: eqeqeq autofix avoids clashes with space-infix-ops (fixes eslint#4423)
missing close rbracket in example
…in-multi Fix: `curly` warns wrong location for `else`
Fix: Support empty if blocks in lines-around-comment (fixes eslint#4339)
Finding range for ==/!= instead of assuming it is next token
Upgrade: Pinned down js-yaml to avoid breaking dep (fixes eslint#4553)
Fix: Bugfix for eqeqeq autofix (fixes eslint#4540)
Fix: lines-around-comment with multiple comments (fixes eslint#3509)
Fix: Ignore space before function in array start (fixes eslint#4569)
Fix: Add for-of to `curly` rule (fixes eslint#4571)
Docs: Reference .eslintrc.* in contributing docs (fixes eslint#4532)
Docs: Update strict rule docs (fixes eslint#4583)
This change locks our fork to New commit to permit only airbnb config package is 2af95dc |
if (filePath.match(/^eslint-config-airbnb.*/)) { | ||
return require(filePath); | ||
} else { | ||
return {} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
💄 Missing semicolon
Minor style thing but otherwise LGTM |
2af95dc
to
fd49900
Compare
thanks @gordondiggs. Fixed 👍 |
👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update our fork of eslint.
Note: eslint made some changes in the configuration that intersected with our changes to permit airbnb packages only. We updated our code accordingly.
cc @codeclimate/review