Abh upstream v1.10.3 #6

ABaldwinHunter · 2015-12-10T20:28:47Z

Update our fork of eslint.

Note: eslint made some changes in the configuration that intersected with our changes to permit airbnb packages only. We updated our code accordingly.

cc @codeclimate/review

…int#4348)

…nt#4220) Also updated docs to note that either node or loc (or both) must be supplied. Code will now throw clearer message if neither is supplied and will not throw TypeError if node is not supplied.

Fix: eslint.report can be called w/o node if loc provided (fixes eslint#4220)

…nt#4359)

…#4364) Refs eslint#4048 Refs eslint#4084 Refs eslint#4351

Fix: Add the missing "as-needed" documentation to the radix rule (fixes eslint#4364)

Fix: Display singular/plural version of "line" in message

Update: Add Popular Style Guides (fixes eslint#4320)

Fix: no-undef-init should ignore const (fixes eslint#4284)

Update: Refactor eslint.verify args (fixes eslint#4395)

…#4423)

Update: Allow empty arrow body (fixes eslint#4411)

Docs: Document semi-spacing behaviour (fixes eslint#4404)

Revert "Update: Allow empty arrow body (fixes eslint#4411)"

Fix: eqeqeq autofix avoids clashes with space-infix-ops (fixes eslint#4423)

missing close rbracket in example

…in-multi Fix: `curly` warns wrong location for `else`

Fix: Support empty if blocks in lines-around-comment (fixes eslint#4339)

…#4438)

Finding range for ==/!= instead of assuming it is next token

Upgrade: [email protected] (fixes eslint#4545)

Upgrade: Pinned down js-yaml to avoid breaking dep (fixes eslint#4553)

Fix: Bugfix for eqeqeq autofix (fixes eslint#4540)

Fix: lines-around-comment with multiple comments (fixes eslint#3509)

Fix: Ignore space before function in array start (fixes eslint#4569)

Fix: Add for-of to `curly` rule (fixes eslint#4571)

Docs: Reference .eslintrc.* in contributing docs (fixes eslint#4532)

Docs: Update strict rule docs (fixes eslint#4583)

ABaldwinHunter · 2015-12-10T20:33:26Z

This change locks our fork to v1.10.3 of eslint.

New commit to permit only airbnb config package is 2af95dc

gdiggs · 2015-12-11T15:16:38Z

lib/config/config-file.js

+        if (filePath.match(/^eslint-config-airbnb.*/)) {
+            return require(filePath);
+        } else {
+            return {}


💄 Missing semicolon

gdiggs · 2015-12-11T15:16:54Z

Minor style thing but otherwise LGTM

ABaldwinHunter · 2015-12-11T15:43:50Z

thanks @gordondiggs. Fixed 👍

gdiggs · 2015-12-11T15:44:43Z

👍

Abh upstream v1.10.3

ipanasenko and others added 30 commits November 6, 2015 21:53

Update: no-implicit-coercion validate AssignmentExpression (fixes esl…

4916dc6

…int#4348)

Fix: eslint.report can be called w/o node if loc provided (fixes esli…

fdfc6cd

…nt#4220) Also updated docs to note that either node or loc (or both) must be supplied. Code will now throw clearer message if neither is supplied and will not throw TypeError if node is not supplied.

Update: Add Popular Style Guides (fixes eslint#4320)

ae696eb

Merge pull request eslint#4314 from platinumazure/context-report

4648b2b

Fix: eslint.report can be called w/o node if loc provided (fixes eslint#4220)

Fix: Display singular/plural version of "line" in message (fixes esli…

b9d1fc6

…nt#4359)

Fix: Add the missing "as-needed" docs to the radix rule (fixes eslint…

ea1da0b

…#4364) Refs eslint#4048 Refs eslint#4084 Refs eslint#4351

Merge pull request eslint#4367 from mzgol/radix-docs

595258b

Fix: Add the missing "as-needed" documentation to the radix rule (fixes eslint#4364)

Merge pull request eslint#4357 from mariusschulz/patch-1

98691d7

Fix: Display singular/plural version of "line" in message

Merge pull request eslint#4340 from xjamundx/style-guides

02afa61

Update: Add Popular Style Guides (fixes eslint#4320)

Fix: no-undef-init should ignore const (fixes eslint#4284)

c58f294

Update: Refactor eslint.verify args (fixes eslint#4395)

22d1e03

Merge pull request eslint#4396 from eslint/issue4284

81c793f

Fix: no-undef-init should ignore const (fixes eslint#4284)

Merge pull request eslint#4398 from eslint/issue4395

425eb7c

Update: Refactor eslint.verify args (fixes eslint#4395)

Fix: Handle comments in comma-spacing (fixes eslint#4389)

a4b3114

Update: Allow empty arrow body (fixes eslint#4411)

013664f

Docs: Document semi-spacing behaviour (fixes eslint#4404)

1ff31d3

Fix: eqeqeq autofix avoids clashes with space-infix-ops (fixes eslint…

1f265b1

…#4423)

Merge pull request eslint#4420 from eslint/issue4411

db6ba1d

Update: Allow empty arrow body (fixes eslint#4411)

Merge pull request eslint#4421 from eslint/issue4404

b2228dc

Docs: Document semi-spacing behaviour (fixes eslint#4404)

Revert "Update: Allow empty arrow body (fixes eslint#4411)"

59920bf

Merge pull request eslint#4425 from eslint/revert-4420-issue4411

0b44234

Revert "Update: Allow empty arrow body (fixes eslint#4411)"

Merge pull request eslint#4424 from platinumazure/fix-eqeqeq-autofix

20d9433

Fix: eqeqeq autofix avoids clashes with space-infix-ops (fixes eslint#4423)

Docs: missing close rbracket in example

5444116

Merge pull request eslint#4422 from storkme/patch-1

957fe08

missing close rbracket in example

Fix: id-length properties never option (fixes eslint#4347)

6d59e0e

Fix: curly warns wrong location for else (fixes eslint#4362)

7b0afc3

Fix: Support empty if blocks in lines-around-comment (fixes eslint#4339)

7092637

Merge pull request eslint#4430 from mysticatea/curly/fix-wrong-error-…

3b3b335

…in-multi Fix: `curly` warns wrong location for `else`

Merge pull request eslint#4433 from eslint/issue4339

804abd8

Fix: Support empty if blocks in lines-around-comment (fixes eslint#4339)

Fix: no-extend-native crashed at empty defineProperty (fixes eslint…

812c263

…#4438)

platinumazure and others added 20 commits November 25, 2015 14:40

Fix: Bugfix for eqeqeq autofix (fixes eslint#4540)

03ff54f

Finding range for ==/!= instead of assuming it is next token

Upgrade: [email protected] (fixes eslint#4545)

d0683f3

Merge pull request eslint#4546 from platinumazure/upgrade-doctrine

3d712c3

Upgrade: [email protected] (fixes eslint#4545)

Fix: lines-around-comment with multiple comments (fixes eslint#3509)

30cd6b0

Upgrade: Pinned down js-yaml to avoid breaking dep (fixes eslint#4553)

76d104d

Merge pull request eslint#4554 from eslint/issue4553

d24519f

Upgrade: Pinned down js-yaml to avoid breaking dep (fixes eslint#4553)

Merge pull request eslint#4544 from platinumazure/eqeqeq-autofix-issue

1a3d095

Fix: Bugfix for eqeqeq autofix (fixes eslint#4540)

Merge pull request eslint#4552 from eslint/issue3509

8b66d65

Fix: lines-around-comment with multiple comments (fixes eslint#3509)

Upgrade: [email protected] (refs eslint#4485)

0f5b86f

1.10.2

931e0a2

Fix: Ignore space before function in array start (fixes eslint#4569)

95d2e0b

Fix: Add for-of to curly rule (fixes eslint#4571)

f01840d

Docs: Reference .eslintrc.* in contributing docs (fixes eslint#4532)

6189ebb

Merge pull request eslint#4572 from eslint/issue4569

58ee960

Fix: Ignore space before function in array start (fixes eslint#4569)

Merge pull request eslint#4573 from kaicataldo/curlyforof

2679a39

Fix: Add for-of to `curly` rule (fixes eslint#4571)

Merge pull request eslint#4577 from kaicataldo/configurationfilesdocs

fdce86d

Docs: Reference .eslintrc.* in contributing docs (fixes eslint#4532)

Docs: Update strict rule docs (fixes eslint#4583)

4e163a7

Merge pull request eslint#4584 from eslint/issue4583

901d525

Docs: Update strict rule docs (fixes eslint#4583)

1.10.3

2436cc6

resolve merge conflict

e28087e

gdiggs reviewed Dec 11, 2015
View reviewed changes

Permit airbnb config packages only

fd49900

ABaldwinHunter force-pushed the abh-upstream-v1.10.3 branch from 2af95dc to fd49900 Compare December 11, 2015 15:42

ABaldwinHunter pushed a commit that referenced this pull request Dec 11, 2015

Merge pull request #6 from codeclimate/abh-upstream-v1.10.3

d24d0b4

Abh upstream v1.10.3

ABaldwinHunter merged commit d24d0b4 into master Dec 11, 2015

ABaldwinHunter deleted the abh-upstream-v1.10.3 branch December 11, 2015 15:45

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Abh upstream v1.10.3 #6

Abh upstream v1.10.3 #6

Uh oh!

ABaldwinHunter commented Dec 10, 2015

Uh oh!

ABaldwinHunter commented Dec 10, 2015

Uh oh!

gdiggs Dec 11, 2015

Uh oh!

gdiggs commented Dec 11, 2015

Uh oh!

ABaldwinHunter commented Dec 11, 2015

Uh oh!

gdiggs commented Dec 11, 2015

Uh oh!

Uh oh!

Abh upstream v1.10.3 #6

Abh upstream v1.10.3 #6

Uh oh!

Conversation

ABaldwinHunter commented Dec 10, 2015

Uh oh!

ABaldwinHunter commented Dec 10, 2015

Uh oh!

gdiggs Dec 11, 2015

Choose a reason for hiding this comment

Uh oh!

gdiggs commented Dec 11, 2015

Uh oh!

ABaldwinHunter commented Dec 11, 2015

Uh oh!

gdiggs commented Dec 11, 2015

Uh oh!

Uh oh!