Skip to content

Abh upstream v1.10.3 #6

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 121 commits into from
Dec 11, 2015
Merged

Abh upstream v1.10.3 #6

merged 121 commits into from
Dec 11, 2015

Conversation

ABaldwinHunter
Copy link

Update our fork of eslint.

Note: eslint made some changes in the configuration that intersected with our changes to permit airbnb packages only. We updated our code accordingly.

cc @codeclimate/review

ipanasenko and others added 30 commits November 6, 2015 21:53
…nt#4220)

Also updated docs to note that either node or loc (or both) must be supplied. Code will now throw clearer message if neither is supplied and will not throw TypeError if node is not supplied.
Fix: eslint.report can be called w/o node if loc provided (fixes eslint#4220)
Fix: Add the missing "as-needed" documentation to the radix rule (fixes eslint#4364)
Fix: Display singular/plural version of "line" in message
Update: Add Popular Style Guides (fixes eslint#4320)
Fix: no-undef-init should ignore const (fixes eslint#4284)
Update: Refactor eslint.verify args (fixes eslint#4395)
Update: Allow empty arrow body (fixes eslint#4411)
Docs: Document semi-spacing behaviour (fixes eslint#4404)
Revert "Update: Allow empty arrow body (fixes eslint#4411)"
Fix: eqeqeq autofix avoids clashes with space-infix-ops (fixes eslint#4423)
missing close rbracket in example
…in-multi

Fix: `curly` warns wrong location for `else`
Fix: Support empty if blocks in lines-around-comment (fixes eslint#4339)
platinumazure and others added 20 commits November 25, 2015 14:40
Finding range for ==/!= instead of assuming it is next token
Upgrade: Pinned down js-yaml to avoid breaking dep (fixes eslint#4553)
Fix: lines-around-comment with multiple comments (fixes eslint#3509)
Fix: Ignore space before function in array start (fixes eslint#4569)
Docs: Reference .eslintrc.* in contributing docs (fixes eslint#4532)
Docs: Update strict rule docs (fixes eslint#4583)
@ABaldwinHunter
Copy link
Author

This change locks our fork to v1.10.3 of eslint.

New commit to permit only airbnb config package is 2af95dc

if (filePath.match(/^eslint-config-airbnb.*/)) {
return require(filePath);
} else {
return {}
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💄 Missing semicolon

@gdiggs
Copy link

gdiggs commented Dec 11, 2015

Minor style thing but otherwise LGTM

@ABaldwinHunter
Copy link
Author

thanks @gordondiggs. Fixed 👍

@gdiggs
Copy link

gdiggs commented Dec 11, 2015

👍

ABaldwinHunter pushed a commit that referenced this pull request Dec 11, 2015
@ABaldwinHunter ABaldwinHunter merged commit d24d0b4 into master Dec 11, 2015
@ABaldwinHunter ABaldwinHunter deleted the abh-upstream-v1.10.3 branch December 11, 2015 15:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.