feat: include user agent in headers #262
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
this will be helpful in the future for debugging customer issues since it will tell us what version of the plugins (at least the bundler core) they're using
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found. Additional details and impacted files
☔ View full report in Codecov by Sentry. |
Codecov ReportAll modified and coverable lines are covered by tests ✅ ✅ All tests successful. No failed tests found.
📢 Thoughts on this report? Let us know! |
Bundle ReportChanges will increase total bundle size by 14.68kB (0.19%) ⬆️. This is within the configured threshold ✅ Detailed changes
Affected Assets, Files, and Routes:view changes for bundle: @codecov/bundler-plugin-core-esmAssets Changed:
view changes for bundle: @codecov/remix-vite-plugin-esmAssets Changed:
view changes for bundle: @codecov/example-next-15-app-client-array-pushAssets Changed:
view changes for bundle: @codecov/rollup-plugin-esmAssets Changed:
view changes for bundle: @codecov/bundler-plugin-core-cjsAssets Changed:
Files in
view changes for bundle: @codecov/sveltekit-plugin-esmAssets Changed:
view changes for bundle: @codecov/example-astro-5-app-server-esmAssets Changed:
view changes for bundle: @codecov/vite-plugin-esmAssets Changed:
view changes for bundle: @codecov/solidstart-plugin-esmAssets Changed:
view changes for bundle: @codecov/bundle-analyzer-esmAssets Changed:
view changes for bundle: @codecov/example-astro-app-server-esmAssets Changed:
view changes for bundle: @codecov/webpack-plugin-esmAssets Changed:
view changes for bundle: @codecov/example-next-app-client-array-pushAssets Changed:
|
Bundle ReportChanges will increase total bundle size by 23.56kB (0.3%) ⬆️. This is within the configured threshold ✅ Detailed changes
Affected Assets, Files, and Routes:view changes for bundle: @codecov/remix-vite-plugin-esmAssets Changed:
view changes for bundle: @codecov/bundler-plugin-core-esmAssets Changed:
view changes for bundle: @codecov/webpack-plugin-esmAssets Changed:
view changes for bundle: @codecov/sveltekit-plugin-esmAssets Changed:
view changes for bundle: @codecov/nuxt-plugin-esmAssets Changed:
view changes for bundle: @codecov/example-next-15-app-client-array-pushAssets Changed:
view changes for bundle: @codecov/example-next-app-client-array-pushAssets Changed:
view changes for bundle: @codecov/vite-plugin-esmAssets Changed:
view changes for bundle: @codecov/example-sveltekit-app-server-esmAssets Changed:
view changes for bundle: @codecov/rollup-plugin-esmAssets Changed:
view changes for bundle: @codecov/bundle-analyzer-esmAssets Changed:
view changes for bundle: @codecov/example-astro-5-app-server-esmAssets Changed:
view changes for bundle: @codecov/bundler-plugin-core-cjsAssets Changed:
Files in
view changes for bundle: @codecov/example-astro-app-server-esmAssets Changed:
view changes for bundle: @codecov/example-sveltekit-app-client-esmAssets Changed:
view changes for bundle: @codecov/nextjs-webpack-plugin-esmAssets Changed:
|
| @@ -53,6 +54,7 @@ export const getPreSignedURL = async ({ | |||
| }: GetPreSignedURLArgs) => { | |||
| const headers = new Headers({ | |||
| "Content-Type": "application/json", | |||
| "User-Agent": `codecov-bundler_plugin/${version}`, | |||
There was a problem hiding this comment.
Is there a reason behind using this mixed casing instead of like codecov-bundler-plugin?
There was a problem hiding this comment.
yeah it's not a great reason, but shelter has some code that splits out the User-Agent by '-' and indexes by 1:
user_agent.split('-')[1] so if i did codecov-bundler-plugin everything after the second - wouldn't be captured
There was a problem hiding this comment.
Oh got it, thanks for the context. It sounds like the current setup in shelter is a bit restrictive - thoughts on tweaking the logic there to handle User-Agent parsing more flexibly? That way, we won't be tied down by the format and can keep things cleaner going forward
Something like:
https://github.com/codecov/shelter/blob/5f7c3ecee45cc50085f8e97cc5647ca7b17f0c8b/libs/helpers.py#L611C1-L622C1
return headers["User-Agent"].split("/")[0].split("-",1)[1]
Do you know why we strip the codecov- in the first place?
There was a problem hiding this comment.
🤷 i don't think there's a reason necessarily, i think it was just to keep the logs more short instead of including the "codecov-" prefix in all the log context
i think it should be fine to change the shelter handling to accommodate this
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this will be helpful in the future for debugging customer issues since it will tell us what version of the plugins (at least the bundler core) they're using