Skip to content

feat: add close_on_exit terminal configuration option #63

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -157,6 +157,7 @@ For deep technical details, see [ARCHITECTURE.md](./ARCHITECTURE.md).
split_width_percentage = 0.30,
provider = "auto", -- "auto", "snacks", or "native"
auto_close = true,
close_on_exit = true, -- Close terminal window when process exits
},

-- Diff Integration
Expand Down
4 changes: 4 additions & 0 deletions lua/claudecode/terminal.lua
Original file line number Diff line number Diff line change
Expand Up @@ -24,6 +24,7 @@ local config = {
show_native_term_exit_tip = true,
terminal_cmd = nil,
auto_close = true,
close_on_exit = true, -- When true, closes terminal window when process exits
}

-- Lazy load providers
Expand Down Expand Up @@ -102,6 +103,7 @@ local function build_config(opts_override)
split_side = effective_config.split_side,
split_width_percentage = effective_config.split_width_percentage,
auto_close = effective_config.auto_close,
close_on_exit = effective_config.close_on_exit,
}
end

Expand Down Expand Up @@ -210,6 +212,8 @@ function M.setup(user_term_config, p_terminal_cmd)
config[k] = v
elseif k == "auto_close" and type(v) == "boolean" then
config[k] = v
elseif k == "close_on_exit" and type(v) == "boolean" then
config[k] = v
else
vim.notify("claudecode.terminal.setup: Invalid value for " .. k .. ": " .. tostring(v), vim.log.levels.WARN)
end
Expand Down
4 changes: 4 additions & 0 deletions lua/claudecode/terminal/native.lua
Original file line number Diff line number Diff line change
Expand Up @@ -98,6 +98,10 @@ local function open_terminal(cmd_string, env_table, effective_config, focus)

cleanup_state() -- Clear our managed state first

if not effective_config.close_on_exit then
return
end

if current_winid_for_job and vim.api.nvim_win_is_valid(current_winid_for_job) then
if current_bufnr_for_job and vim.api.nvim_buf_is_valid(current_bufnr_for_job) then
-- Optional: Check if the window still holds the same terminal buffer
Expand Down
4 changes: 3 additions & 1 deletion lua/claudecode/terminal/snacks.lua
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,9 @@ local function setup_terminal_events(term_instance, config)
-- Clean up
terminal = nil
vim.schedule(function()
term_instance:close({ buf = true })
if config.close_on_exit then
term_instance:close({ buf = true })
end
vim.cmd.checktime()
end)
end, { buf = true })
Expand Down