Skip to content

Add social badges #2142

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Oct 6, 2020
Merged

Add social badges #2142

merged 2 commits into from
Oct 6, 2020

Conversation

bpmct
Copy link
Member

@bpmct bpmct commented Sep 29, 2020

No description provided.

@bpmct bpmct requested a review from nhooyr September 29, 2020 16:48
@bpmct bpmct requested a review from code-asher as a code owner September 29, 2020 16:48
Copy link
Member

@code-asher code-asher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thoughts on putting it inline at the top like https://github.com/facebook/react? Although I guess it wouldn't fit unless we shortened some text a bit.

@bpmct
Copy link
Member Author

bpmct commented Sep 30, 2020

@code-asher how's that?

@code-asher
Copy link
Member

I think it looks awesome!

Copy link
Contributor

@nhooyr nhooyr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice!

@code-asher
Copy link
Member

Our checks don't seem to run when they're from another repo. Gonna go ahead and merge this though.

@code-asher code-asher merged commit b415b75 into coder:master Oct 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants