Skip to content

chore(deps): upgrade path-parse in test/yarn.lock #4428

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 3, 2021
Merged

Conversation

jsjoeio
Copy link
Contributor

@jsjoeio jsjoeio commented Nov 2, 2021

This PR fixes a minor issue with path-parse in test/yarn.lock.

Fixes #4279

@jsjoeio jsjoeio added the dependencies Pull requests that update a dependency file label Nov 2, 2021
@jsjoeio jsjoeio self-assigned this Nov 2, 2021
@jsjoeio jsjoeio requested a review from a team as a code owner November 2, 2021 23:06
@github-actions
Copy link

github-actions bot commented Nov 2, 2021

✨ Coder.com for PR #4428 deployed! It will be updated on every commit.

@codecov
Copy link

codecov bot commented Nov 2, 2021

Codecov Report

Merging #4428 (590be68) into main (946e4e8) will not change coverage.
The diff coverage is n/a.

❗ Current head 590be68 differs from pull request most recent head 187d0b1. Consider uploading reports for the commit 187d0b1 to get more accurate results
Impacted file tree graph

@@           Coverage Diff           @@
##             main    #4428   +/-   ##
=======================================
  Coverage   66.29%   66.29%           
=======================================
  Files          31       31           
  Lines        1620     1620           
  Branches      316      316           
=======================================
  Hits         1074     1074           
  Misses        468      468           
  Partials       78       78           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 946e4e8...187d0b1. Read the comment docs.

@jsjoeio
Copy link
Contributor Author

jsjoeio commented Nov 2, 2021

Argh, macOS build failed. Not sure if we need to do this. I'll cancel and rerun

@jsjoeio
Copy link
Contributor Author

jsjoeio commented Nov 3, 2021

Not sure why the audit-ci is timing out (didn't change anything there) but otherwise, this passed CI so merging

image

@jsjoeio jsjoeio merged commit 13e91de into main Nov 3, 2021
@jsjoeio jsjoeio deleted the jsjoeio-fix-deps branch November 3, 2021 17:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Security Vulnerability CVE-2021-23406 inside /usr/lib/code-server/vendor/modules/code-oss-dev/yarn.lock
2 participants