Skip to content

Fix #163 -- Lazily get i18n locale name #164

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 5, 2022
Merged

Fix #163 -- Lazily get i18n locale name #164

merged 1 commit into from
Nov 5, 2022

Conversation

codingjoe
Copy link
Owner

A widget instance can leak the i18n setting to another request
or be stuck on the default language setting.

@codecov
Copy link

codecov bot commented Nov 5, 2022

Codecov Report

Base: 99.25% // Head: 99.25% // No change to project coverage 👍

Coverage data is based on head (f0ae2f9) compared to base (5894b52).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #164   +/-   ##
=======================================
  Coverage   99.25%   99.25%           
=======================================
  Files           7        7           
  Lines         267      267           
=======================================
  Hits          265      265           
  Misses          2        2           
Impacted Files Coverage Δ
django_select2/forms.py 100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@codingjoe codingjoe force-pushed the issues/163 branch 4 times, most recently from 04ee445 to 97e9c27 Compare November 5, 2022 11:31
A widget instance can leak the i18n setting to another request
or be stuck on the default language setting.
Copy link

@arneatec arneatec left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should fix the issue adequately according to my experiences with the issue.

@codingjoe codingjoe merged commit 10d5e8d into main Nov 5, 2022
@codingjoe codingjoe deleted the issues/163 branch November 5, 2022 13:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants