Skip to content

fix(frontend): remove defaultProps from react-scroll-to-bottom #757

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 17, 2024

Conversation

lx-0
Copy link
Contributor

@lx-0 lx-0 commented Sep 2, 2024

This fixes the React warnings of package react-scroll-to-bottom regarding defaultProps. Package development seems to be stalled at the moment, therefore applying as patch.

Fix is automatically applied when running node package install.

Reference: PR on react-scroll-to-bottom

Copy link
Collaborator

@tomtobac tomtobac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

awesome! @lx-0 thank you so much! 🙇

btw, I tried to fix also the hydratation warning using suppressHydrationWarning at Panel or BasicScrollToBottomCore but I was unlucky :(

@lx-0 lx-0 closed this Sep 4, 2024
@lx-0 lx-0 force-pushed the fix/remove-default-props branch from 0849036 to ca5ab66 Compare September 4, 2024 19:57
@lx-0 lx-0 reopened this Sep 4, 2024
@tianjing-li tianjing-li added this pull request to the merge queue Sep 17, 2024
Merged via the queue into cohere-ai:main with commit 9fa773c Sep 17, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants