This repository was archived by the owner on Dec 10, 2021. It is now read-only.
GP-860 - Port features from comicrelief/omnipay-worldpay-cg-hosted
#2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Support more secure 'username', distinct from merchant code * Detect and handle errors better, especially generic CDATA text in an <error>
adamclark-dev
suggested changes
Nov 29, 2017
| @@ -12,13 +12,21 @@ | |||
| */ | |||
| class Response extends AbstractResponse | |||
| { | |||
| /** @var string */ | |||
| protected static $PAYMENT_STATUS_AUTHORISED = 'AUTHORISED'; | |||
There was a problem hiding this comment.
Yep probably. I don't think they worked in the other repo with the Trait & these were the closest functional equivalent. Will constant-ify in this repo for now.
adamclark-dev
previously approved these changes
Nov 29, 2017
adamclark-dev
approved these changes
Nov 29, 2017
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
<error>This is mostly copied from changes I made on the Hosted adapter, but because this one doesn't yet have models to handle Notifications, its
Responsemethods are all directly in the class rather than partly in a shared Trait.