Skip to content

Reduce cling llvm cache (makes room for Emscripten llvm 20 builds) #550

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 3, 2025

Conversation

mcbarton
Copy link
Collaborator

@mcbarton mcbarton commented Apr 2, 2025

Description

Please include a summary of changes, motivation and context for this PR.

Currently we are have just enough room in the cache to include the native builds of llvm 20 (see image below). My plan was to remove the llvm 19 Windows job to make room for the Emscripten llvm 20, but that won't be enough given we are so close to capacity. This PR should reduce the impact of the cling llvm builds enough that we have enough room for the Emscripten builds. I'll be able to quantify the impact of this PR once the workflows finish running.

image

Checklist

  • I have read the contribution guide recently

@mcbarton mcbarton changed the title Reduce cling llvm cache Reduce cling llvm cache (makes room for Emscripten llvm 20 builds) Apr 2, 2025
Copy link

codecov bot commented Apr 2, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 75.94%. Comparing base (3258584) to head (69201d3).
Report is 2 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #550   +/-   ##
=======================================
  Coverage   75.94%   75.94%           
=======================================
  Files           9        9           
  Lines        3646     3646           
=======================================
  Hits         2769     2769           
  Misses        877      877           
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@mcbarton
Copy link
Collaborator Author

mcbarton commented Apr 3, 2025

This PR would save 120mb of cache space, which although not much, when you add on the space saved by removing the llvm 19 Windows job (450mb), then you have enough space for all Emscripten llvm 20 jobs.

@anutosh491
Copy link
Collaborator

Went through this!
To be fair my knowledge with respect to how the cache works with respect to the CI is very limited 😅
Can someone help us with the reviews here ?

@mcbarton
Copy link
Collaborator Author

mcbarton commented Apr 3, 2025

@anutosh491 To see the space savings go here https://github.com/compiler-research/CppInterOp/actions/caches . Here is the example of one such space saving. Search 'bbbc20b4c96929d3b7d8f9a83c9987f9a154a569-refs/tags/v1.0-macOS-macos-13-clang-clang-13.x-patch-none' and you'll see it has the cache size 190mb on main . If you then go to the second page you'll see that the size of that cache for this PR (refs/pull/550/merge) is 170mb. If you did this one by one you'll see each of the 6 jobs gets a cache 20mb smaller, totaling the 120mb I state above. Hope this helps.

All I've done as part of this PR is delete files from the cling repo after if its built, which we don't need once cling has been built.

Copy link
Collaborator

@anutosh491 anutosh491 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure, I think the above explanation makes sense !
I'll let you merge this when you're happy.

@mcbarton mcbarton merged commit c3384fb into compiler-research:main Apr 3, 2025
71 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants