-
Notifications
You must be signed in to change notification settings - Fork 31
Removed "include new" from Interpreter constructor #561
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
clang-tidy made some suggestions
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
clang-tidy made some suggestions
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
clang-tidy made some suggestions
clang-tidy review says "All clean, LGTM! 👍" |
1 similar comment
clang-tidy review says "All clean, LGTM! 👍" |
Hmmm I am confused. Why do I see llvm being built again ? Shouldn't the cache be simply put to use ? |
I cleared one cache job last night, to merge main into my llvm 20 PR. It seems to have caused a cascade effect where other cache jobs get cancelled (this happens occasionally when we are near the limit). I will cancel the workflows for this PR, rebuild the cache on main, and we should be back to normal. It will take about 2 hours to rebuild the cache on main |
The cache on main has been rebuilt, so this PR should be ok to be worked on now. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #561 +/- ##
==========================================
- Coverage 75.94% 75.93% -0.02%
==========================================
Files 9 9
Lines 3646 3644 -2
==========================================
- Hits 2769 2767 -2
Misses 877 877
🚀 New features to boost your workflow:
|
clang-tidy review says "All clean, LGTM! 👍" |
yeah. i have done it. sorry for those commit messages. i did some mistake while commiting from my side. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tried this on my local fork and the changes look good.
Approving (can be merged after CI passes)
clang-tidy review says "All clean, LGTM! 👍" |
1 similar comment
clang-tidy review says "All clean, LGTM! 👍" |
@anutosh491 You will need to look at it again, as another commit was put in after you approved. |
Yupp it was a commit regarding improving a test. I made Abhinav aware of it on chat on discord hence I've been following the changes here ;) |
No description provided.