Skip to content

Removed "include new" from Interpreter constructor #561

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Apr 14, 2025

Conversation

kr-2003
Copy link
Contributor

@kr-2003 kr-2003 commented Apr 14, 2025

No description provided.

Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

clang-tidy made some suggestions

Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

clang-tidy made some suggestions

Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

clang-tidy made some suggestions

Copy link
Contributor

clang-tidy review says "All clean, LGTM! 👍"

1 similar comment
Copy link
Contributor

clang-tidy review says "All clean, LGTM! 👍"

@anutosh491
Copy link
Collaborator

Hmmm I am confused. Why do I see llvm being built again ? Shouldn't the cache be simply put to use ?

@mcbarton
Copy link
Collaborator

Hmmm I am confused. Why do I see llvm being built again ? Shouldn't the cache be simply put to use ?

I cleared one cache job last night, to merge main into my llvm 20 PR. It seems to have caused a cascade effect where other cache jobs get cancelled (this happens occasionally when we are near the limit). I will cancel the workflows for this PR, rebuild the cache on main, and we should be back to normal. It will take about 2 hours to rebuild the cache on main

@mcbarton
Copy link
Collaborator

The cache on main has been rebuilt, so this PR should be ok to be worked on now.

@mcbarton
Copy link
Collaborator

mcbarton commented Apr 14, 2025

@kr-2003 These commit seem really strange 96c2e96 and c825154 being in the history of the PR. Can you squash your commits, so its not in the list of commits? You've also got a large number of commits with a single letter for a commit message, which isn't helpful.

Copy link

codecov bot commented Apr 14, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 75.93%. Comparing base (ddd67a2) to head (4651c6f).
Report is 1 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #561      +/-   ##
==========================================
- Coverage   75.94%   75.93%   -0.02%     
==========================================
  Files           9        9              
  Lines        3646     3644       -2     
==========================================
- Hits         2769     2767       -2     
  Misses        877      877              
Files with missing lines Coverage Δ
lib/Interpreter/CppInterOpInterpreter.h 80.11% <ø> (-0.22%) ⬇️
Files with missing lines Coverage Δ
lib/Interpreter/CppInterOpInterpreter.h 80.11% <ø> (-0.22%) ⬇️
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Contributor

clang-tidy review says "All clean, LGTM! 👍"

@kr-2003
Copy link
Contributor Author

kr-2003 commented Apr 14, 2025

@kr-2003 These commit seem really strange 96c2e96 and c825154 being in the history of the PR. Can you squash your commits, so its not in the list of commits? You've also got a large number of commits with a single letter for a commit message, which isn't helpful.

yeah. i have done it. sorry for those commit messages. i did some mistake while commiting from my side.

Copy link
Collaborator

@anutosh491 anutosh491 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tried this on my local fork and the changes look good.

Approving (can be merged after CI passes)

Copy link
Contributor

clang-tidy review says "All clean, LGTM! 👍"

1 similar comment
Copy link
Contributor

clang-tidy review says "All clean, LGTM! 👍"

@mcbarton
Copy link
Collaborator

Tried this on my local fork and the changes look good.

Approving (can be merged after CI passes)

@anutosh491 You will need to look at it again, as another commit was put in after you approved.

@anutosh491
Copy link
Collaborator

You will need to look at it again, as another commit was put in after you approved.

Yupp it was a commit regarding improving a test. I made Abhinav aware of it on chat on discord hence I've been following the changes here ;)

@mcbarton mcbarton merged commit 96045bd into compiler-research:main Apr 14, 2025
149 of 155 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants