Add _Concurrency module.
#24
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
compnerd
requested changes
Sep 24, 2021
| target_link_libraries(swiftConcurrencyShims PUBLIC | ||
| swiftCore) | ||
| target_link_options(swiftConcurrencyShims PRIVATE | ||
| "SHELL:-Xclang-linker -nostdlib") |
There was a problem hiding this comment.
I wonder if this is something that we should keep. We do want the dependency on other language runtimes once the code will be added.
There was a problem hiding this comment.
I don't feel strongly, but it might be good future proofing. And it matches what we do everywhere else.
There was a problem hiding this comment.
Fair enough, leaving this for now won't hurt anything.
This is an empty module that silences compiler warnings.
zoecarver
force-pushed
the
concurrency-module
branch
from
7236e1f to
643f654
Compare
compnerd
approved these changes
Sep 24, 2021
|
@compnerd thanks for landing both of these! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an empty module that silences compiler errors.