-
-
Notifications
You must be signed in to change notification settings - Fork 296
Update errored version updates version formatting #2233
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update errored version updates version formatting #2233
Conversation
✅ Deploy Preview for conda-forge-previews ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
I am not sure whether |
Probably, yes. But we should fix how the bot emits these errors so it's a better looking Markdown. We could also process the HTML-in-Markdown thingy, but that's a bit too much? Let me see if I can find how we emit these error blobs. Edit: Here it is. It boils down to passing the exception message directly, plus some minor massaging. We could maybe prettify the "header", but the exception message is what it is. The changes in the frontend, as they are, look good to me. |
Yes this has been on my todo list and I agree. Let's merge the pr here and we can merge a change in the bot. Unfortunately we may have to go back and edit the existing blobs to make everything look nice. |
I see two ways to do this:
{
"status": str, // I guess we only have 'error' here?
"n_attempts": int,
"job_url": str,
"branch": str,
"message": str
} I think long term JSON makes more sense but I don't know how tricky that would be. WDYT? |
What do we do for the migration errors? We should follow that maybe? |
@jaimergp for the version updates, we need to adjust this line: https://github.com/regro/cf-scripts/blob/98f3ea00203e7a7d33d43e1d6c791e2227d778f1/conda_forge_tick/auto_tick.py#L632 The one you linked is for plain migrators. |
Oh weird, now I see both things in both places. |
OK see this PR: #2234 |
Thanks @HaudinFlorence. Closing this one in favor of #2234. We might revisit this section of the status page in the future, though. I'll keep you posted! |
@jaimergp Ok. Thanks for the input. |
PR Checklist:
docs/
orcommunity/
, you have added it to the sidebar in the corresponding_sidebar.json
fileThis PR aims at fixing task 11 of issue #2137
For the errored version updates, it replaces
<pre>
by<Markdown>
components with relevant properties.