Skip to content

Add conflict for php-http/discovery:1.16.0 #45

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 17, 2023
Merged

Conversation

fritzmg
Copy link
Contributor

@fritzmg fritzmg commented May 17, 2023

There is a regression in php-http/discovery:1.16.0 which was released an hour ago (php-http/message#152 (comment)).

@fritzmg fritzmg requested a review from a team May 17, 2023 07:52
@fritzmg fritzmg self-assigned this May 17, 2023
@leofeyer leofeyer merged commit cfe3746 into contao:main May 17, 2023
@leofeyer
Copy link
Member

Thank you @fritzmg.

@nicolas-grekas
Copy link

Please don't do that !

@nicolas-grekas
Copy link

The correct fix is two steps:

  1. require php-http/message-factory directly, since you apparently need it
  2. later on: figure out why you need php-http/message-factory and replace that need by PSR-17

@fritzmg fritzmg deleted the patch-3 branch May 17, 2023 08:00
@fritzmg
Copy link
Contributor Author

fritzmg commented May 17, 2023

Please don't do that !

We need to do that, otherwise existing and new installations will break.

@Toflar
Copy link
Member

Toflar commented May 17, 2023

We will investigate and apply the right fix in later versions but for the time being, contao/conflicts is our way to make sure people can continue to install current versions.

@fritzmg
Copy link
Contributor Author

fritzmg commented May 17, 2023

The correct fix is two steps:

  1. require php-http/message-factory directly, since you apparently need it
  2. later on: figure out why you need php-http/message-factory and replace that need by PSR-17

@nicolas-grekas we don't use anything from php-http directly. php-http/message and php-http/discovery is installed via friendsofsymfony/http-cache. Apparently php-http/discovery then wants to automatically discover a HTTP client, however we already require symfony/http-client.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants