-
Notifications
You must be signed in to change notification settings - Fork 777
P3480R6 std::simd is a range #7998
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
c42ed8a
to
b4176cc
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changes look correct, but missing index entries.
using iterator = \exposid{simd-iterator}<basic_simd>; | ||
using const_iterator = \exposid{simd-iterator}<const basic_simd>; | ||
|
||
constexpr iterator begin() noexcept { return {*this, 0}; } | ||
constexpr const_iterator begin() const noexcept { return {*this, 0}; } | ||
constexpr const_iterator cbegin() const noexcept { return {*this, 0}; } | ||
constexpr default_sentinel_t end() const noexcept { return {}; } | ||
constexpr default_sentinel_t cend() const noexcept { return {}; } |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seeing that these are entirely defined within the synopsis, we should have some \indexlibrarymember
macros above.
Same for basic_simd_mask
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We have \libmember for inline indexing inside codeblocks. "grep" for examples.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The members of simd-iterator do not get indexed, right? (because it's an exposition-only type? OTOH its members are public API.)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also, looking at some more examples of indexing, there's a lot of index macros missing for [simd]. I guess I should add all those as editorial commit after the motions.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking at ranges.tex
, the exposition-only iterators are fully indexed. So I guess I could do that as well.
I'll close this PR in favor of a single PR that includes all 4 simd motions ASAP.
Fixes #7948
Fixes cplusplus/papers#2134