GitHub Action to run cpplint on pushes & pull requests #3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is a much simpler solution that loads quickly but does not require a custom Dockerfile.
tkruse
approved these changes
Dec 8, 2019
|
feel free to merge. I leave it to you in case you are experimenting. |
Farwaykorse
added a commit
to Farwaykorse/fwkSudoku
that referenced
this pull request
Dec 17, 2019
cpplint/GitHub-Action-for-cpplint#3 No more docker image required
|
It would probably now make sense to convert this to a composite action, so people can benefit from any potential internal improvements to the action such as annotations, without them having to manually update what's effectively currently a workflow template: |
|
@peternewman : I am not up-to-date with github actions, and there is a lot to read. Do you have any current obviously beneficial example for how composite action would improve user experience with this action? |
|
Also, the billing implications of using composite actions? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a much simpler solution that loads quickly but does not require a custom Dockerfile.