Skip to content

Verify SSL as True by default #385

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 29, 2020
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions CHANGES.txt
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,10 @@ Unreleased

- Added official Python 3.9 support.

- BREAKING CHANGE: The driver now verifies SSL certificates when connecting via
HTTP by default. Previously, this setting defaulted to false. This setting
can be changed via the ``verify_ssl_cert`` connection parameter.

2020/09/28 0.26.0
=================

Expand Down
2 changes: 1 addition & 1 deletion docs/sqlalchemy.rst
Original file line number Diff line number Diff line change
Expand Up @@ -105,7 +105,7 @@ the ``connect_args`` argument, like so::
When you do this, the Database API layer will use its :ref:`round-robin
<multiple-nodes>` implementation.

The client does not validate `SSL server certificates`_ by default. To configure
The client validates `SSL server certificates`_ by default. To configure
this behaviour, SSL verification options can be passed in via ``connect_args``
too::

Expand Down
4 changes: 2 additions & 2 deletions src/crate/client/connection.py
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,7 @@ def __init__(self,
timeout=None,
backoff_factor=0,
client=None,
verify_ssl_cert=False,
verify_ssl_cert=True,
ca_cert=None,
error_trace=False,
cert_file=None,
Expand Down Expand Up @@ -62,7 +62,7 @@ def __init__(self,
client used to communicate with crate.
:param verify_ssl_cert:
if set to ``True`` verify the servers SSL server certificate.
defaults to ``False``
defaults to ``True``
:param ca_cert:
a path to a CA certificate to use when verifying the SSL server
certificate.
Expand Down
2 changes: 1 addition & 1 deletion src/crate/client/doctests/sqlalchemy.txt
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,7 @@ The ``connect_args`` parameter has to be used to do so::
... })
Engine(crate://)

As defined in :ref:`https_connection` the client does not validate SSL server
As defined in :ref:`https_connection` the client validates SSL server
certificates by default. To configure this behaviour, SSL verification options
can be given via ``connect_args`` too::

Expand Down