support active model serializers

[simonweil]

Please add support for Active Model Serializers Gem.
https://github.com/rails-api/active_model_serializers

[ctran]

Could you provide a bit more details? A PR is even better :-)

[simonweil]

Which details can help?

Looking at the code it seems that the right place to add this would be in "annotate_models.rb" adding a new pattern: SERIALIZER_PATTERNS and an exclusion option for serializers.

Is this the correct direction?

[ctran]

Sounds good to me.

[rusterholz]

+1! Now that Serializers are included by default in Rails 4, formally adding support for this would be especially desirable. Can this be revisited? Our team would love it.

@drewda's fork appears to have support for this, so AFAIK it should be as simple as pulling in his fork and fixing any borked regressions.

[drewda]

My PR is features complete, but I didn't add any test coverage. Help from
someone more familiar with the test suite would be great.
On Feb 13, 2015 3:39 PM, "Andy Rusterholz" notifications@github.com wrote:

+1! Now that Serializers are included by default in Rails 4, formally
adding support for this would be especially desirable. Can this be
revisited? Our team would love it.

@drewda https://github.com/drewda's fork appears to have support for
this, so AFAIK it should be as simple as pulling in his fork and fixing any
borked regressions.

—
Reply to this email directly or view it on GitHub
#148 (comment)
.

[rusterholz]

@ctran It's been over a year since this issue was opened, and almost five months since @drewda's PR. Could that be merged?

[ctran]

I don't remember there was a PR on this.

[drewda]

Two duplicate PRs:

• support ActiveModel::Serializers #148 #213
• Active Model Serializers #219

In any case, there's now support for serializers.

[ctran]

Cool!

[simonweil]

Great, thanks!