Support grand grand scope #2773
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
phillco
reviewed
Jan 26, 2025
| @@ -233,7 +233,11 @@ The modifier `"grand"` can be used to select the parent of the containing syntac | |||
| - `"take grand statement air"` | |||
| - `"take grand funk air"` | |||
|
|
|||
| For example, the command `"take grand statement [blue] air"` will select that parent statement of the statement containing the token with a blue hat over the letter 'a'. | |||
| For example, the command `"take grand statement [blue] air"` will select the parent statement of the statement containing the token with a blue hat over the letter 'a'. | |||
There was a problem hiding this comment.
We discussed a bit about having unique terms for 1st/2nd/3rd parent as shortcuts, but noone came obviously to mind. There is also the existing awkwardness of the second parent most likely being something like "grandparent" but that is ambiguous with the generic parent command. Historically, parent wasn't chosen as "grand" because it is long and awkward to say and we assumed most people are just looking for the first or second parent.
phillco
approved these changes
Jan 26, 2025
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
cursorless-bot
pushed a commit
that referenced
this pull request
Jan 26, 2025
Allows you to say grand multiple times. eg `"take grand grand state"` Fixes #2152 ## Checklist - [x] I have added [tests](https://www.cursorless.org/docs/contributing/test-case-recorder/) - [x] I have updated the [docs](https://github.com/cursorless-dev/cursorless/tree/main/docs) and [cheatsheet](https://github.com/cursorless-dev/cursorless/tree/main/cursorless-talon/src/cheatsheet) - [x] I have not broken the cheatsheet
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allows you to say grand multiple times. eg
"take grand grand state"Fixes #2152
Checklist