Escape constants #1187
Merged
Escape constants #1187
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Why did a bunch of links go away in your expected results? |
|
It's a manual process to regenerate the reference docs, and the PR before me didn't include the regened docs. It makes this PR a little noisy - |
| @@ -1260,12 +1260,12 @@ String topLevelFunction(int param1, bool param2, Cool coolBeans, | |||
| }); | |||
|
|
|||
| test('COLOR_ORANGE has correct value', () { | |||
| expect(orangeConstant.constantValue, "'orange'"); | |||
| expect(orangeConstant.constantValue, "'orange'"); | |||
There was a problem hiding this comment.
It might be worth adding a test for documentation of a generic, since that was the failing case in flutter. Doesn't look like current testing covers Foo<Bar,Baz>
|
|
|
lgtm! There is a test that checks the changes against the checked in docs and flags for regen. Looks like the test is not quite working. opened #1190 to track. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@keertip